New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AJAX loading indicator does not properly stop after receiving a redirect response to a file download #5055
Comments
@datune If you have time, would you mind providing us with a test case to the Test plugin demonstrating this issue? |
I do confirm this behavior. |
@mjauvin Do you have a test case I can review for it? |
No, I don't. |
public function onTestRedirect()
{
return redirect()->to('path/to/file/to/be/downloaded/by/the/browser.csv');
} |
Thanks @LukeTowers, but I do know how to do a redirect ;). I was simply asking if someone might've set up a link or action with an AJAX handler and the necessary attributes to show the loader, ie. |
Oh, sorry about that @bennothommo, thought you were confused about the exact implementation of the handler. I believe all AJAX requests in the backend trigger the stripe loading indicator though don't they? |
I have the same behavior. I have the download page as follows:
I have an ajax handler that redirects to this page:
The steps are the following:
Everything works as expected until here. After I finish the download, as mentioned in the title, the AJAX loading indicators (from the top of the page and the loading circle that replaces the mouse pointer) reappear. The only way to bring the page back to normal is to do a manual refresh. |
This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
…ct response via AJAX. Fixes: octobercms/october#5555 Tested by wintercms/wn-test-plugin@9fb25e2 Refs: - octobercms/october#5055 (original issue attempted to solve with previous code) - octobercms/october#2780 (original issue regarding the hash change redirect not closing the loading indicator) - octobercms/october@99a0861 (October's solution to the issue)
…ator (#70) Fix issue with premature hiding of loading indicators during a redirect response via AJAX. Fixes: octobercms/october#5555 Tested by wintercms/wn-test-plugin@9fb25e2 Refs: - octobercms/october#5055 (original issue attempted to solve with previous code) - octobercms/october#5321 (solution to octobercms/october#5055) - octobercms/october#2780 (original issue regarding the hash change redirect not closing the loading indicator) - octobercms/october@99a0861 (October's solution to the issue)
…ator (#70) Fix issue with premature hiding of loading indicators during a redirect response via AJAX. Fixes: octobercms/october#5555 Tested by wintercms/wn-test-plugin@9fb25e2 Refs: - octobercms/october#5055 (original issue attempted to solve with previous code) - octobercms/october#5321 (solution to octobercms/october#5055) - octobercms/october#2780 (original issue regarding the hash change redirect not closing the loading indicator) - octobercms/october@99a0861 (October's solution to the issue)
…ct response via AJAX. Fixes: octobercms/october#5555 Tested by wintercms/wn-test-plugin@9fb25e2 Refs: - octobercms/october#5055 (original issue attempted to solve with previous code) - octobercms/october#2780 (original issue regarding the hash change redirect not closing the loading indicator) - octobercms/october@99a0861 (October's solution to the issue)
No description provided.
The text was updated successfully, but these errors were encountered: